CoW: Avoid copying Index in Series constructor #52008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Index
jorisvandenbossche
approved these changes
Mar 16, 2023
| @@ -399,7 +399,8 @@ def inferred_type(self) -> str: | |||
| """Return a string of the type inferred from the values""" | |||
| return "interval" | |||
|
|
|||
| @Appender(Index.memory_usage.__doc__) | |||
| # Cannot determine type of "memory_usage" | |||
| @Appender(Index.memory_usage.__doc__) # type: ignore[has-type] | |||
There was a problem hiding this comment.
How is this related?
There was a problem hiding this comment.
This seems like a mypy bug.
Adding
from pandas._libs.internals import BlockValuesRefs
to the base file causes this
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
phofl
added a commit
to phofl/pandas
that referenced
this pull request
Mar 17, 2023
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.